Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove propTypes definitions from Newest Products block #9613

Merged
merged 5 commits into from
May 29, 2023

Conversation

hritikchaudhary
Copy link
Contributor

@hritikchaudhary hritikchaudhary commented May 27, 2023

Fixes #9517

Changes in the PR:

Removed propTypes definitions from Newest Products block, price filters, add-to-cart and product-list block.

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

User Facing Testing

  • Do not include in the Testing Notes

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

@hritikchaudhary hritikchaudhary changed the title Remove propTypes definitions from Newest Products block, price filters, add-to-cart and product-list Remove propTypes definitions from Newest Products block May 27, 2023
@nielslange nielslange mentioned this pull request May 28, 2023
@nielslange nielslange self-requested a review May 29, 2023 03:14
@nielslange nielslange added type: refactor The issue/PR is related to refactoring. skip-changelog PRs that you don't want to appear in the changelog. block: newest products Issues related to the Newest Products block. labels May 29, 2023
Copy link
Member

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, @hritikchaudhary! All CI checks in #9620 passed, and the changes look great. I'll merge this PR now. 😀

@nielslange nielslange added this to the 10.4.0 milestone May 29, 2023
@nielslange nielslange merged commit ac2b6d6 into woocommerce:trunk May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: newest products Issues related to the Newest Products block. skip-changelog PRs that you don't want to appear in the changelog. type: community contribution type: refactor The issue/PR is related to refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert block.js to block.tsx and replace propTypes with TypeScript definitions
2 participants